Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added acceptsFirstMouse for controlRegionView #1288

Merged
merged 1 commit into from
Mar 24, 2015

Conversation

deepak1556
Copy link
Member

fixes #1286 , but should this be a default behaviour or configurable one ?

hmm, i dont seem to find a reason to not make this default behaviour for a draggable region in frameless window.

@zcbenz
Copy link
Member

zcbenz commented Mar 24, 2015

It sounds reasonable to make draggable region "acceptsFirstMouse " by default, thanks!

zcbenz added a commit that referenced this pull request Mar 24, 2015
added acceptsFirstMouse for controlRegionView
@zcbenz zcbenz merged commit c4b2401 into electron:master Mar 24, 2015
@deepak1556 deepak1556 deleted the native_window_mac_patch branch April 6, 2015 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

accept-first-mouse does not work on -webkit-app-region: drag
2 participants