fix: opt into location services once device service has been started #14253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
alexeykuzmin
suggested changes
Aug 22, 2018
codebytere
approved these changes
Aug 22, 2018
There was a problem hiding this comment.
I wish we could add a test, but sadly I'm 99% sure new payment models for API keys mean that we currently can't :(
Let's add a follow-up issue to see if we can circle back to and address that but for now if it's locally tested to work i'd rather get it out in the next beta
|
@codebytere its possible to mock the geolocation response for our tests, will update the PR shortly. |
deepak1556
force-pushed
the
geolocation_mojo_patch
branch
2 times, most recently
from
85a0553
to
8141cd5
Compare
|
@alexeykuzmin have added the specs, #14263 needs to be verified and merged before this PR since the specs and implementation rely on it. |
deepak1556
force-pushed
the
geolocation_mojo_patch
branch
from
8141cd5
to
e5147f1
Compare
deepak1556
force-pushed
the
geolocation_mojo_patch
branch
from
e5147f1
to
d47f9ab
Compare
alexeykuzmin
approved these changes
Aug 23, 2018
ckerr
approved these changes
Aug 23, 2018
|
Release Notes Persisted
|
|
An error occurred while attempting to backport this PR to "3-0-x", |
codebytere
pushed a commit
that referenced
this pull request
Aug 24, 2018
…14253) * fix: opt into location services once device service has been started * refactor: provide fake location provider to mock geolocation reponses * chore: add spec for navigator.geolocation api using fake location provider
Merged
3 tasks
codebytere
pushed a commit
that referenced
this pull request
Aug 24, 2018
…14253) * fix: opt into location services once device service has been started * refactor: provide fake location provider to mock geolocation reponses * chore: add spec for navigator.geolocation api using fake location provider
codebytere
added a commit
that referenced
this pull request
Aug 24, 2018
…(backport: 3-0-x) (#14289) * fix: opt into location services once device service has been started (#14253) * fix: opt into location services once device service has been started * refactor: provide fake location provider to mock geolocation reponses * chore: add spec for navigator.geolocation api using fake location provider * fix conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The global permission for opting into geolocation services was trying to get initialized before the device service was started, this patch fixes it by initializing it as a part of the permission request as every geolocation api call is guaranteed to hit the permission manager before further processing.
Fixes #14111
Depends on electron/libchromiumcontent#659
Checklist
npm testpassesRelease Notes
Notes: opt into location services once device service has been started