Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript typedefinitions coalesce deprecations and removal #14753

Closed
davidnorthetal opened this issue Sep 21, 2018 · 1 comment
Closed

TypeScript typedefinitions coalesce deprecations and removal #14753

davidnorthetal opened this issue Sep 21, 2018 · 1 comment

Comments

@davidnorthetal
Copy link

via #14692 - when Electron 3.0.0 got released, the electron.d.ts typedefinition file that is generated from the API documentation removed makeSingleInstance tho it's only documented as deprecated (and the electron-js files still contain it).

So in effect, from TypeScript's perspective whenever a JavaScript function becomes deprecated, it becomes instantly removed altogether for TypeScript.

This to me seems very much like an oversight/bug, especially because the already existing breaking-changes documentation doesn't specifically mention this in any way.


I'd expect this to be resolved in two ways: either the typescript definition files actually start differentiating deprecation/removal or I'd suggest that the breaking changes documentation mentions how TypeScript files always remove and never deprecate.

Thanks for any response/input on this matter.
Dnorth

@MarshallOfSound
Copy link
Member

Closing this out as we now leave deprecated APIs in the docs until they are actually removed from the codebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
3.0.x / 3.1.x
Unsorted Issues
Development

No branches or pull requests

3 participants