You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@davidnorthetal The TS definitions are generated from our docs and this deprecated API was removed from the docs and replaced with its new version requestSingleInstanceLock when we deprecated makeSingleInstance which did happen in 3.0. (we deprecate in 3.0 and remove in 4.0)
@MarshallOfSound why did you close this? - I can see that this is the case, but isn't that clearly a bug?
If it's deprecated, it's deprecated, not gone. It's literally gone from TypeScripts perspective, not deprecated.
Is there a specification for how you guys deal with this? - Because to me this very much seems like an oversight.
node_modules/.bin/electron --version
: v3.0.0node_modules/.bin/electron --version
on last known working Electron version (if applicable): v2.0.5Expected Behavior
I compile my TypeScript electron application.
No errors
Actual behavior
I compile my TypeScript electron application.
error TS2339: Property 'makeSingleInstance' does not exist on type 'App'.
Additional Information
makeSingleInstance
got removed here: dcd580bwhile this commit WAS NOT merged into 3.0.0 ( which is correct, according to https://github.com/electron/electron/blob/master/docs/api/breaking-changes.md#planned-breaking-api-changes-40 ), apparently the TypeScript definition got still removed
The text was updated successfully, but these errors were encountered: