Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TouchBarScrubber does not expose layout options #16936

Open
pelmers opened this issue Feb 13, 2019 · 2 comments
Open

TouchBarScrubber does not expose layout options #16936

pelmers opened this issue Feb 13, 2019 · 2 comments

Comments

@pelmers
Copy link

pelmers commented Feb 13, 2019

In #11038 dynamic width calculation was added to the scrubber touch bar item layout, however there is no way to specify the itemSpacing and itemSize (https://developer.apple.com/documentation/appkit/nsscrubberflowlayout?language=objc) for entries in the scrubber list, which are necessary to emulate the appearance of the TouchBarSegmentedControl class.

Desired: (TouchBarSegmentedControl)
screen shot 2019-02-13 at 12 37 02 pm

Current appearance: (Scrubber)
screen shot 2019-02-13 at 12 36 26 pm

Request: Likely the simplest solution would be to add optional itemSpacing and itemSize properties to the TouchBarScrubber constructor options and use those in sizeForItemAtIndex if given (https://github.com/dashersw/electron/blob/master/atom/browser/ui/cocoa/atom_touch_bar.mm#L670).

@welcome
Copy link

welcome bot commented Feb 13, 2019

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

To help make it easier for us to investigate your issue, please follow the contributing guidelines.

@MarshallOfSound
Copy link
Member

@pelmers This sounds like a reasonable enhancement, is this something you'd be willing to take a shot at? Happy to help walk you through the Electron codebase if you want to give it a go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants