Atom Framework.framework fails to codesign

[probablycorey]

According to this blog codesigning has changed in Mavericks. So we now need to codesign included frameworks and apps individually.

This shouldn't be a problem Atom Shell needs to worry about because we can codesign the frameworks when Atom is built. For codesigning these work fine:

codesign -f -vvv -s 'Developer ID Application: GitHub' out/Release/Atom\ Helper.app
out/Release/Atom Helper.app: signed bundle with Mach-O thin (x86_64) [com.github.atom.helper]

codesign -f -vvv -s 'Developer ID Application: GitHub' frameworks/Mantle.framework 
frameworks/Mantle.framework: signed bundle with Mach-O thin (x86_64) [com.github.Mantle]

But Atom Framework.framework fails to codesign:

codesign -f -vvv -s 'Developer ID Application: GitHub' out/Release/Atom\ Framework.framework
out/Release/Atom Framework.framework: bundle format unrecognized, invalid, or unsuitable

[zcbenz]

This was caused by lack of Info.plist in Atom Framework.framework, and is fixed now. And you also need to pass --deep to codesign: http://stackoverflow.com/a/17396143/682252.

[probablycorey]

Awesome, thanks!

[thebyrd]

I upgraded to Yosemite and now this has stopped working. I'm using the most recent atom shell release.

I also found this: http://furbo.org/2013/10/17/code-signing-and-mavericks/

$ codesign --verbose --deep --force --sign "Company, LLC." Atom.app
Atom.app: bundle format is ambiguous (could be app or framework)
In subcomponent: /Users/david/Downloads/Atom.app/Contents/Frameworks/Atom Framework.framework

[zcbenz]

@thebyrd Can you open a new issue for this?

[thebyrd]

Yep, #720