Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac App Store rejects the build with 5.0.0-beta* #17197

Closed
mulyk opened this issue Mar 2, 2019 · 3 comments
Closed

Mac App Store rejects the build with 5.0.0-beta* #17197

mulyk opened this issue Mar 2, 2019 · 3 comments

Comments

@mulyk
Copy link

mulyk commented Mar 2, 2019

  • Electron Version:
    • 5.0.0-beta.4

Rejection Email

Guideline 2.5.1 - Performance - Software Requirements

Your app uses or references the following non-public APIs:

Found private symbol usage.
Symbol: __LSSetApplicationLaunchServicesServerConnectionStatus
From framework: /System/Library/Frameworks/CoreServices.framework/Versions/A/CoreServices
Symbol: _SetApplicationIsDaemon
From framework: /System/Library/Frameworks/ApplicationServices.framework/Versions/A/ApplicationServices
Symbols: _pthread_chdir_np, _pthread_fchdir_np, _abort_report_np
From framework: /usr/lib/libSystem.B.dylib
In binary: Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework

The use of non-public APIs is not permitted on the App Store, because it can lead to a poor user experience should these APIs change.

We are constantly reevaluating and identifying non-public APIs that you may have been using for an extended period of time. You should always use public APIs and frameworks and ensure they are up-to-date to prevent this issue in the future

Additional Information

Version 4 has no problems.

@mulyk mulyk changed the title Mac App Store rejects the app Mac App Store rejects the build with 5.0.0-beta* Mar 2, 2019
@MarshallOfSound
Copy link
Member

These API calls appear to have been introduced in https://chromium-review.googlesource.com/c/chromium/src/+/1183624/

@nornagon
Copy link
Member

nornagon commented Mar 4, 2019

@MarshallOfSound the _LSSetApplicationLaunchServicesServerConnectionStatus yes, but not:

  • _SetApplicationIsDaemon
  • _pthread_chdir_np
  • _pthread_fchdir_np
  • _abort_report_np

@MarshallOfSound
Copy link
Member

Yeah mb, didn't see the others in the report, the others were all introduced recently as well. E.g. abort_report_np --> https://chromium-review.googlesource.com/c/chromium/src/+/1270175

The solution here is probably just comment most of this out 🤔

@MarshallOfSound MarshallOfSound self-assigned this Mar 4, 2019
@sofianguy sofianguy added this to Unsorted Issues in 5.0.x Mar 5, 2019
@sofianguy sofianguy moved this from Unsorted Issues to Blocks Stable in 5.0.x Mar 7, 2019
@sofianguy sofianguy moved this from Blocks Stable to Fixed for Next Release in 5.0.x Mar 13, 2019
@sofianguy sofianguy moved this from Fixed for Next Release to Fixed in 5.0.0-beta.6 in 5.0.x Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
5.0.x
Fixed in 5.0.0-beta.6
Development

No branches or pull requests

3 participants