New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove usage of private APIs in the MAS build #17224
Conversation
From: Samuel Attard <sattard@slack-corp.com> | ||
Date: Mon, 4 Mar 2019 14:46:48 -0800 | ||
Subject: fix: disable usage of pthread_fchdir_np and pthread_chdir_np in MAS | ||
builds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hrrrrm is this what export-patches
produced? the 2-line subject line is probably gonna cause issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, this is exactly what the script produced. It looks like the builds are OK and handle it though?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmm... does it survive import-patches && export-patches
? if not, might have to kick the export-patches
script
From: Samuel Attard <sattard@slack-corp.com> | ||
Date: Mon, 4 Mar 2019 14:51:45 -0800 | ||
Subject: fix: disable usage of SetApplicationIsDaemon and | ||
_LSSetApplicationLaunchServicesServerConnectionStatus in MAS builds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@nornagon we already have disabled seatbelt for MAS builds, wouldn't it better if we add dummy build groups for targets in |
@deepak1556 would we have to provide stubs for functions/classes that other modules depend on? If so, that seems like it might not actually be easier, since we'd have to track that API. |
|
cdcfd02
to
55552bb
Compare
@codebytere Rebased on master to fix those issues 👍 |
Release Notes Persisted
|
/trop run backport-to 5-0-x |
The backport process for this PR has been manually initiated, |
I have automatically backported this PR to "5-0-x", please check out #17293 |
* fix: remove usage of abort_report_np in MAS builds * fix: remove usage of pthread_chdir in MAS builds * fix: remove usage of setapplicationisdaemon in MAS builds * chore: update patch manifest
Description of Change
This PR introduces patches to remove / replace usages of private APIs used in the MAS build.
Please note this PR includes 3 separate patches each solving their own problem, it would probably make sense to rebase and merge this rather than squash and merge in order to retain history.
Fixes #17197
Release Notes
Notes: Fixed some MAS rejection errors by removing usages of private APIs