Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registering global shortcuts not working from v5.0.0-beta.3 #17246

Closed
ErnestoGarciaGenesys opened this issue Mar 6, 2019 · 2 comments
Closed

Comments

@ErnestoGarciaGenesys
Copy link

  • Electron Version:
    • v5.0.0-beta.3 - v5.0.0-beta.5
  • Operating System:
    • Windows 10
  • Last Known Working Electron version::
    • v5.0.0-beta.2

Expected Behavior

This should work, and registered must be assigned true:

registered = globalShortcut.register("Super+Alt+Up", function () { console.log("hotkey!!")})

Actual Behavior

Shortcut is not registered, for no key combinations as far as I can tell. Return value is always false.

To Reproduce

Just run the code line above.

@welcome
Copy link

welcome bot commented Mar 6, 2019

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

To help make it easier for us to investigate your issue, please follow the contributing guidelines.

@codebytere codebytere self-assigned this Mar 6, 2019
@sofianguy sofianguy added this to Unsorted Issues in 5.0.x Mar 6, 2019
@sofianguy sofianguy moved this from Unsorted Issues to Blocks Stable in 5.0.x Mar 7, 2019
@brenca
Copy link
Contributor

brenca commented Mar 26, 2019

I can confirm that this is happening, there is an upstream partial fix for this, I'll post a followup fix upstream to make things work a 100%, and then I'll backport those fixes to master and 5-0-x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
5.0.x
Fixed for Next Release
Development

No branches or pull requests

4 participants