Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rename atomBinding to electronBinding #17419

Merged
merged 1 commit into from
Mar 18, 2019
Merged

chore: rename atomBinding to electronBinding #17419

merged 1 commit into from
Mar 18, 2019

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Mar 16, 2019 •
edited

Description of Change

Rename atomBinding to electronBinding to mitigate ongoing confusion from folks who have no clue why atom is sprinkled all over the codebase.

Checklist

Release Notes

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 16, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Mar 17, 2019
MarshallOfSound
MarshallOfSound approved these changes Mar 18, 2019
View reviewed changes
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit 👍

nornagon
nornagon approved these changes Mar 18, 2019
View reviewed changes
Copy link
Member

@nornagon nornagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet

@codebytere codebytere merged commit 38d7501 into master Mar 18, 2019
@release-clerk
Copy link

release-clerk bot commented Mar 18, 2019

No Release Notes

@codebytere codebytere deleted the atom-binding-electron branch March 18, 2019 19:37
@miniak miniak mentioned this pull request Apr 24, 2019
Merged
3 tasks
kiku-jw pushed a commit to kiku-jw/electron that referenced this pull request May 16, 2019
@codebytere @kiku-jw
chore: rename atomBinding to electronBinding (electron#17419)
7475f40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@miniak miniak miniak approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@codebytere @nornagon @miniak @MarshallOfSound