refactor: use IPC helpers in window-setup #17948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miniak
force-pushed
the
miniak/guest-window-manager
branch
3 times, most recently
from
59c4ea4
to
5310baf
Compare
miniak
force-pushed
the
miniak/guest-window-manager
branch
3 times, most recently
from
26b0578
to
26988ce
Compare
miniak
force-pushed
the
miniak/guest-window-manager
branch
from
26988ce
to
e25e784
Compare
miniak
force-pushed
the
miniak/guest-window-manager
branch
3 times, most recently
from
26ae333
to
092f727
Compare
3 tasks
miniak
force-pushed
the
miniak/guest-window-manager
branch
from
092f727
to
5ebfa8f
Compare
miniak
force-pushed
the
miniak/guest-window-manager
branch
from
5ebfa8f
to
f17d5ba
Compare
miniak
force-pushed
the
miniak/guest-window-manager
branch
4 times, most recently
from
bda10be
to
9ed2c83
Compare
miniak
changed the title
miniak
force-pushed
the
miniak/guest-window-manager
branch
2 times, most recently
from
d96ea01
to
c0d8cc6
Compare
alexeykuzmin
reviewed
Jul 5, 2019
alexeykuzmin
reviewed
Jul 5, 2019
miniak
force-pushed
the
miniak/guest-window-manager
branch
from
c0d8cc6
to
058b386
Compare
miniak
force-pushed
the
miniak/guest-window-manager
branch
from
058b386
to
870dafc
Compare
nornagon
approved these changes
Jul 8, 2019
|
No Release Notes |
alexeykuzmin
approved these changes
Jul 8, 2019
3 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Use
ipcRendererUtils.invoke(Sync)/ipcMainUtils.handleto eliminate duplicate code and properly propagate errors to the caller side.We need to handle
loadURLsimilar to #18990Checklist
npm testpassesRelease Notes
Notes: no-notes