Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle gzipped chrome WebUI resources #18552

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented May 31, 2019

Backport of #18531

See that PR for details.

Notes: Fixed issues where some chrome://* URLs would not render correctly

Fixes: #18503
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/1576232

For whatever reason Chromium made this change and then made the default
//content behavior to return false for all IsDataResourceGzipped
requests.  This PR updates our ContentClient impl to return the correct
values.

Notes: Fixed issues where some `chrome://*` URLs would not render
correctly
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 31, 2019
@trop trop bot added 6-0-x backport This is a backport PR labels May 31, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 31, 2019
@MarshallOfSound MarshallOfSound merged commit 7871e18 into 6-0-x May 31, 2019
@release-clerk
Copy link

release-clerk bot commented May 31, 2019

Release Notes Persisted

Fixed issues where some chrome://* URLs would not render correctly

@MarshallOfSound MarshallOfSound deleted the trop/6-0-x-bp-fix-handle-gzipped-chrome-webui-resources-1559333157207 branch May 31, 2019 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6-0-x backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants