Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove scripts in the tools dir that are unused #18944

Merged
merged 1 commit into from
Jun 23, 2019

Conversation

MarshallOfSound
Copy link
Member

@MarshallOfSound MarshallOfSound commented Jun 23, 2019

I'm cleaning up the tools and scripts folder, looks like most of the stuff in tools was from the GYP days or sometimes even earlier, no need to keep it around anymore

Part 1 of N

Notes: no-notes

@codebytere
Copy link
Member

before we ditch these, do we know where they were all used at one point in time so we can be sure we don't need them anymore?

@MarshallOfSound
Copy link
Member Author

@codebytere Yeah I traced them all to be sure, I'll put a quick list below.

  • atom_source_root.js used in GYP bootstrap for < 1.8
  • dump-version-info.js replaced by metadumper
  • get-endianess used in ancient GYP bootstrap
  • pkg-config-wrapper used in GYP sysroot land
  • rewrite_dirs used in GYP sysroot land
  • sysroot_ld_paths more GYP sysroot stuff
  • make_locale_paks used in GYP building days, GN / chromium build scripts does this for us now
  • run-electron yeah idk, back in GYP days, it points back to out/D which is a GYP thing

@MarshallOfSound MarshallOfSound merged commit 79ac99c into master Jun 23, 2019
@release-clerk
Copy link

release-clerk bot commented Jun 23, 2019

No Release Notes

@MarshallOfSound MarshallOfSound deleted the remove-unused-tools branch June 23, 2019 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants