fix: set size of GTK about panel icon #18957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckerr
reviewed
Jun 24, 2019
codebytere
force-pushed
the
force-size-about-panel-gtk
branch
2 times, most recently
from
3604980
to
4c35c63
Compare
codebytere
force-pushed
the
force-size-about-panel-gtk
branch
from
4c35c63
to
84613a9
Compare
codebytere
force-pushed
the
force-size-about-panel-gtk
branch
from
84613a9
to
72538f0
Compare
|
Release Notes Persisted
|
|
/trop run backport-to 6-0-x,5-0-x |
|
The backport process for this PR has been manually initiated, |
|
The backport process for this PR has been manually initiated, |
|
I was unable to backport this PR to "6-0-x" cleanly; |
|
I was unable to backport this PR to "5-0-x" cleanly; |
|
A maintainer has manually backported this PR to "6-0-x", please check out #19572 |
codebytere
added a commit
that referenced
this pull request
Aug 1, 2019
MarshallOfSound
pushed a commit
that referenced
this pull request
Aug 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Refs #3 on #18918.
Previously, we unconditionally passed through whatever icon was at the
iconPathpassed to a new Linux about panel. On other platforms, it's standardized, and so this PR changes previous behavior such that any icon can be passed in and will be automatically resized to 64x64 pixels while retaining the aspect ratio.cc @ckerr @sindresorhus @MarshallOfSound
Checklist
npm testpassesRelease Notes
Notes: Standardized the about panel icon size on Linux.