Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

browser/api/lib/window.coffee #3

Closed
probablycorey opened this issue May 14, 2013 · 1 comment
Closed

browser/api/lib/window.coffee #3

probablycorey opened this issue May 14, 2013 · 1 comment

Comments

@probablycorey
Copy link

What do you think about renaming window.coffee to something else? The reason is it is confusing to have the DOM window object and to have the OS window object. We could call it browserWindow or atomWindow or you can convince me that we should keep it called window.
@zcbenz zcbenz closed this as completed in 072ac8b May 15, 2013
@zcbenz
Copy link
Member

zcbenz commented May 15, 2013

I agree that the name window makes many confusions, it's now renamed to browser_window.

zcbenz pushed a commit that referenced this issue Sep 11, 2015
@GoooIce
Merge pull request #3 from atom/master
a1cd806 
更新一下啊
zcbenz pushed a commit that referenced this issue Sep 28, 2015
@etiktin
Merge pull request #3 from atom/master
25a2f28 
Update from original
zcbenz pushed a commit that referenced this issue Nov 16, 2015
@brenca
Merge pull request #3 from atom/master
9987082 
Update from original
@ladenberger ladenberger mentioned this issue Jan 15, 2016
Closed
@ruipimentel ruipimentel mentioned this issue Feb 12, 2016
Closed
zcbenz pushed a commit that referenced this issue Feb 16, 2016
@brenca
Merge pull request #3 from atom/master
d5bdb17 
update as upstream
zcbenz pushed a commit that referenced this issue Mar 9, 2016
@wujingke
Merge pull request #3 from heyunjiang/master
da0a1ea 
api doc 4th
@niknickolas niknickolas mentioned this issue Mar 11, 2016
Closed
@mitchhentges mitchhentges mentioned this issue Mar 21, 2016
Closed
zcbenz pushed a commit that referenced this issue Apr 19, 2016
@Stone-Jay
Merge pull request #3 from electron/master
ace235b 
update from electron
@tejohnso tejohnso mentioned this issue Jun 13, 2016
Closed
@ns ns mentioned this issue Feb 6, 2017
Closed
kevinsawicki pushed a commit that referenced this issue May 9, 2017
@aroben
Store the disk cache in an app-specific location
602d3ff 
We deduce the name of the application from the CFBundleName of the .app bundle
and use a path based on that. Similar logic should be implementable for other
platforms.

Fixes #3.
kevinsawicki pushed a commit that referenced this issue May 9, 2017
@aroben
Store the disk cache in an app-specific location
e1b5e5e 
We deduce the name of the application from the CFBundleName of the .app bundle
and use a path based on that. Similar logic should be implementable for other
platforms.

Fixes #3.
zeke pushed a commit that referenced this issue Oct 9, 2017
@excfergodst
Merge pull request #3 from excfergodst/patch-4
b02691c 
Create size.md
@avengerweb avengerweb mentioned this issue Oct 13, 2017
Closed
@vanessayuenn vanessayuenn mentioned this issue Nov 13, 2017
Merged
@ClarkWang-2013 ClarkWang-2013 mentioned this issue Nov 23, 2017
Merged
@astrotars astrotars mentioned this issue Dec 1, 2017
Closed
MarshallOfSound pushed a commit that referenced this issue May 1, 2018
@zcbenz
Merge pull request #3 from paulcbetts/chrome49
38834cb 
basictypes.h => macros.h
@nehbit nehbit mentioned this issue Jun 27, 2018
Closed
@payitforwardnow payitforwardnow mentioned this issue Aug 11, 2018
Closed
@sxmpasch sxmpasch mentioned this issue Oct 2, 2018
Closed
@ckerr ckerr mentioned this issue Oct 24, 2018
Closed
@bdsexton bdsexton mentioned this issue Apr 8, 2019
Closed
@ericpyle ericpyle mentioned this issue May 8, 2019
Closed
@codebytere codebytere mentioned this issue Jun 24, 2019
Merged
5 tasks
sentialx added a commit to sentialx/electron that referenced this issue Apr 8, 2021
@sentialx
Merge pull request electron#3 from sentialx/webui
a14ec82
@nornagon nornagon mentioned this issue May 7, 2021
Merged
This was referenced Dec 16, 2021
Merged
Merged
Merged
@ppontes ppontes mentioned this issue Mar 12, 2022
Merged
@Kilian Kilian mentioned this issue Apr 26, 2022
Open
3 tasks
@chust0788 chust0788 mentioned this issue Apr 28, 2022
Closed
3 tasks
This was referenced Aug 16, 2023
Merged
Merged
Closed
This was referenced Aug 17, 2023
Merged
Merged
Merged
This was referenced Sep 6, 2023
Merged
Merged
Merged
This was referenced Sep 19, 2023
Merged
Merged
This was referenced Oct 3, 2023
Merged
Merged
Merged
Merged
@wujinli wujinli mentioned this issue Jan 31, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@probablycorey @zcbenz