test: run all tests on arm linux platforms #19318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkleinsc
changed the title
codebytere
approved these changes
Jul 18, 2019
|
No Release Notes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
When we started splitting out tests (eg #17325) we never accomodated for the arm CI which wasn't using
script/spec-runner.jsbecause there are (acceptable) failures that happen during yarn/npm install but that script fails if yarn/npm install fails.This PR updates
script/spec-runner.jsto look for an environment variable,IGNORE_YARN_INSTALL_ERRORwhich will allow the spec runner to continue even if there were errors during yarn install.Running all the tests on arm/arm64 revealed a couple of additional issues that we resolved by modifying our Azure Pipelines agents so that the user that runs the test is now a non-root user.
Additionally arm64 CI was updated to use ubuntu:18.04 instead of ubuntu:16.04 to be consistent with the rest of our linux CI.
Checklist
npm testpassesRelease Notes
Notes: no-notes