-
Notifications
You must be signed in to change notification settings - Fork 15.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: breakpad symbols appear to be broken on Windows #19475
Comments
I can't reproduce this. Here's what I did:
Here's the stack that minidump_stackwalk produced:
Which looks like a sensible stack to me, except that the top frame isn't named. I suspect that's because we don't do this base::debug::Alias thing, though not 100% sure. |
@nornagon On Mac it looks not that bad, I agree. We see the same stacktrace in the App Center. Could you please check Windows?, it's a more important platform than Mac. |
Worse in what way? |
I believe this is due to the fact that the symbols in v5.0.7 and higher are named
|
Preflight Checklist
Issue Details
Expected Behavior
Breakpad symbols can be used to symbolicate crashes.
Actual Behavior
Crash information on Windows is barely useful.
Here are first lines of symbolicated crashes on different platforms from App Center.
Linux 🎉
Electron 3
Electron 5.0.7
Mac 👍 😞
Electron 3
Electron 5.0.7
Windows 😢
Electron 3
Electron 5.0.7
To Reproduce
Set up a crash reporter and run
process.crash()
.Additional Information
Probably related to #19157, /cc @nornagon.
The text was updated successfully, but these errors were encountered: