Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support authentication with session.resolveProxy() #20215

Open
3 tasks done
chrmarti opened this issue Sep 12, 2019 · 0 comments
Open
3 tasks done

Support authentication with session.resolveProxy() #20215

chrmarti opened this issue Sep 12, 2019 · 0 comments

Comments

@chrmarti
Copy link

Preflight Checklist

  • I have read the Contributing Guidelines for this project.
  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Problem Description

I'm using session.resolveProxy() to add proxy support to VS Code's extensions. That is currently missing support for authentication because session.resolveProxy() does not return credentials stored in the OS' proxy settings.

Proposed Solution

session.resolveProxy() should include credentials stored in the OS' proxy settings.

Alternatives Considered

Someone should write a Node module doing this. Getting it right across platforms might be the main challenge. Not sure if Chromium's implementation for reading proxy settings could be extracted to make it reusable as a Node module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants