Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release notes script does a bad job of weeding out fixes that have already landed in previous branches #20660

Closed
ckerr opened this issue Oct 21, 2019 · 1 comment

Comments

@ckerr
Copy link
Member

ckerr commented Oct 21, 2019

The release notes script generates a lot of entries in the 7.0.0 notes that should be omitted because they include fixes that were already included in previous releases.

For example, #19941 was included. Its description reads:

Backport of #19912

See that PR for details.

Notes: Fixed command-line scheme arguments from spilling over into each other.

And #19912 has a merged/6-0-x label. The 6-0-x backport was PR #19940 which was merged in 6b77e2e, so this should not have been included in the 7.0.0 release notes.

Invocation was

$ ./release/notes/index.js origin/6-0-x..origin/7-0-x --version v7.0.0 --explicit-links
@nornagon
Copy link
Member

nornagon commented Mar 9, 2022

I think we do a lot better on this now!

@nornagon nornagon closed this as completed Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants