New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: command-line scheme switch values' spillover #19912
Conversation
The value of one of the scheme command-line switches shouldn't spill over into other switches. Fixes #19911
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rad catch 🌟
Release Notes Persisted
|
I have automatically backported this PR to "5-0-x", please check out #19939 |
I have automatically backported this PR to "6-0-x", please check out #19940 |
I have automatically backported this PR to "7-0-x", please check out #19941 |
A maintainer has manually backported this PR to "4-2-x", please check out #19954 |
Description of Change
Fixes #19911: don't spill command-line switch scheme values into other switches.
In addition, this PR uses move semantics to move the tokens from a temporary container into their destination container.
Verified by adding this temporary code to the end of
AtomContentClient::AddAdditionalSchemes()
:and invoking Electron with
--standard-schemes=foo,bar,mum
.Without PR:
With PR:
(
file
andchrome-extension
are added automatically and unrelated to this PR).ChecklistAtomContentClient::AddAdditionalSchemes
npm test
passesRelease Notes
Notes: Fixed command-line scheme arguments from spilling over into each other.