Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webContents.login event not triggered in 7.0.0 #20752

Closed
3 tasks done
binux opened this issue Oct 25, 2019 · 3 comments · Fixed by #20954
Closed
3 tasks done

webContents.login event not triggered in 7.0.0 #20752

binux opened this issue Oct 25, 2019 · 3 comments · Fixed by #20954

Comments

@binux
Copy link

binux commented Oct 25, 2019

Preflight Checklist

  • I have read the Contributing Guidelines for this project.
  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for an issue that matches the one I want to file, without success.

Issue Details

  • Electron Version:
    • 7.0.0
  • Operating System:
    • macOS
  • Last Known Working Electron version:
    • 6.1.2

Expected Behavior

https://github.com/electron/electron/blob/v7.0.0/docs/api/web-contents.md#event-login triggered

Actual Behavior

login event not triggered

To Reproduce

run following code

const {app, BrowserWindow} = require('electron')
app.once('ready', async () => {
  win = new BrowserWindow()
  app.on('login', console.log)
  win.webContents.on('login', console.log)
  win.webContents.once('did-finish-load', async () => {
    const html = await win.webContents.executeJavaScript('document.documentElement.innerHTML')
    console.log(html)
    app.quit()
  })
  await win.webContents.loadURL('https://httpbin.org/basic-auth/user/passwd')
})
@nornagon
Copy link
Member

nornagon commented Nov 4, 2019

Yeah, unfortunately the 'login' event was a casualty of us refactoring on top of Chromium's new 'network service' code. It's currently just ... not attached at all. Whoops. https://github.com/electron/electron/blob/7-0-x/shell/browser/login_handler.cc#L37-L39

@sowelie
Copy link

sowelie commented Nov 7, 2019

Any thoughts on when this will be implemented? This is holding me back from updating to 7.x. Is there anything I can do to help with the fix?

@gavinkalika
Copy link

any movement on this getting fixed?

@sofianguy sofianguy moved this from Unsorted Issues to Fixed for Next Release in 7.2.x Nov 19, 2019
@sofianguy sofianguy added this to Fixed in 8.0.0-beta.3 in 8.2.x Nov 21, 2019
@sofianguy sofianguy moved this from Fixed for Next Release to Fixed in 7.1.2 in 7.2.x Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
7.2.x
Fixed in 7.1.2
8.2.x
Fixed in 8.0.0-beta.3
Development

Successfully merging a pull request may close this issue.

5 participants