Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

window.close in WebView no longer fires close event #2149

Closed
anaisbetts opened this issue Jul 7, 2015 · 3 comments
Closed

window.close in WebView no longer fires close event #2149

anaisbetts opened this issue Jul 7, 2015 · 3 comments
Labels
component/webview

Comments

@anaisbetts
Copy link
Contributor

This worked in 0.28.3 but no longer works in 0.29.2 on Ubuntu where I tested it at least, working on a test for it at the moment:

  1. Create a WebView tag, load any page
  2. $0.addEventListener('close', function() { console.log("It closed!") });
  3. $0.openDevTools()
  4. In dev tools: window.close()
@zcbenz zcbenz added the bug label Jul 8, 2015
@anaisbetts anaisbetts mentioned this issue Jul 8, 2015
Merged
@zcbenz
Copy link
Member

zcbenz commented Jul 10, 2015

Sorry I accidentally renamed it to closed in some other pull request, will change it back.

@zcbenz zcbenz closed this as completed in 4379d24 Jul 10, 2015
@techninja techninja mentioned this issue Jul 13, 2015
Closed
@anaisbetts anaisbetts reopened this Jul 13, 2015
@anaisbetts
Copy link
Contributor Author

Still seeing this even though it doesn't repro on a clean WebView - it seems related to navigation? In the app, we use it in the login page, so we'll navigate a bunch, POST a form, then get redirected to a page whose contents is just <html><script>window.close()</script></html>. That window.close() doesn't end up firing either close or closed. I'm going to try to get a better unit test going

@zcbenz
Copy link
Member

zcbenz commented Sep 17, 2015

It is probably related to the bug that POST request would make the page have no node integration, since that bug had already been fixed, and I'm not able to reproduce this anymore, I'm closing this issue.

@zcbenz zcbenz closed this as completed Sep 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/webview
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anaisbetts @zcbenz