Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test to verify the WebView close event #2161

Merged
merged 1 commit into from
Jul 10, 2015
Merged

Add a test to verify the WebView close event #2161

merged 1 commit into from
Jul 10, 2015

Conversation

anaisbetts
Copy link
Contributor

This PR adds a spec to ensure the WebView's close event fires when a page calls close

@anaisbetts
Copy link
Contributor Author

cc #2149

zcbenz added a commit that referenced this pull request Jul 10, 2015
@zcbenz
Merge pull request #2161 from atom/close-test
fedf764 
Add a test to verify the WebView close event
@zcbenz zcbenz merged commit fedf764 into master Jul 10, 2015
@zcbenz zcbenz deleted the close-test branch July 10, 2015 02:36
@zcbenz
Copy link
Member

zcbenz commented Jul 10, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anaisbetts @zcbenz