Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: specify target arch on mksnapshot #21871

Merged
merged 1 commit into from Jan 23, 2020
Merged

test: specify target arch on mksnapshot #21871

merged 1 commit into from Jan 23, 2020

Conversation

jkleinsc
Copy link
Contributor

Description of Change

Fixes failing mksnapshot tests, eg: https://circleci.com/gh/electron/electron/443219

Checklist

Release Notes

Notes: no-notes

@jkleinsc
Copy link
Contributor Author

Merging as CI failure unrelated to PR change.

@jkleinsc jkleinsc merged commit c92edc8 into master Jan 23, 2020
@release-clerk
Copy link

release-clerk bot commented Jan 23, 2020

No Release Notes

@jkleinsc jkleinsc deleted the fix-mksnapshot-test branch January 23, 2020 17:54
@jkleinsc jkleinsc mentioned this pull request Jan 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jkleinsc @zcbenz