feat: add events for spellcheck dictionary downloads #22449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarshallOfSound
added
target/8-x-y
semver/minor
MarshallOfSound
force-pushed
the
dictionary-download-events
branch
2 times, most recently
from
2eaa5ec
to
c506e8e
Compare
zcbenz
approved these changes
Mar 2, 2020
Closed
3 tasks
MarshallOfSound
force-pushed
the
dictionary-download-events
branch
from
c506e8e
to
aaa2255
Compare
codebytere
approved these changes
Mar 5, 2020
|
Release Notes Persisted
|
|
I was unable to backport this PR to "8-x-y" cleanly; |
|
I have automatically backported this PR to "9-x-y", please check out #22556 |
|
@MarshallOfSound has manually backported this PR to "8-x-y", please check out #22558 |
|
This was approved for backport to 9-x-y and 8-x-y by the releases WG. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in title and notes 馃槃 Pretty standard wiring, had to patch in a way to attach observers to the dictionaries that the spellcheck service creates but that's pretty minimal.
Notes: Added new
spellcheck-dictionary-*events on the `session module to help track and debug dictionary initialization