Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Still cannot figure out how to use setSpellCheckerDictionaryDownloadURL in Electron 8.0.2 #22482

Closed
3 tasks done
heronhaye opened this issue Mar 2, 2020 · 3 comments · Fixed by #22483
Closed
3 tasks done

Comments

@heronhaye
Copy link

Preflight Checklist

  • I have read the Contributing Guidelines for this project.
  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for an issue that matches the one I want to file, without success.

Issue Details

  • Electron Version:
    • v8.0.2
  • Operating System:
    • Arch Linux
  • Last Known Working Electron version:
    • N/A

Expected Behavior

Electron to download dictionary files from custom mirror after setting setSpellCheckerDictionaryDownloadURL to the directory path containing dictionary files in hunspell_dictionaries.zip

Actual Behavior

It doesn't download the files, and spellchecking doesn't work.

To Reproduce

Please see sample code at https://github.com/heronhaye/electron-8-spellchecker-test. Specifically,

  win.webContents.session.setSpellCheckerDictionaryDownloadURL(
    'https://modalduality.keybase.pub/dictionaries/'
  )

Screenshots

Additional Information

@MarshallOfSound helped me figure out that I was using this function incorrectly before, but now I believe I am using it correctly, but still cannot get it to work. Is there an working example base path somewhere on the internet that I can test it on?

@MarshallOfSound
Copy link
Member

@heronhaye Hey sorry I was just about to PR up some more documentation today, we're going through the same steps right now so we're finding these things as well.

TLDR is Chromium might request the lowercase version of the dictionary name i.e. en-us-8... instead of en-US-8..... You can either:

  • Make the file server case insensitive
  • Upload the lower case version of each file as well

I'll close this out with a docs PR shortly.

@MarshallOfSound
Copy link
Member

We're also adding events to make these issues easier to debug in the future

@heronhaye
Copy link
Author

@MarshallOfSound Excellent, I uploaded the lower-case version and it works perfectly. Thank you for the quick responses!

EvanHahn-Signal added a commit to EvanHahn-Signal/electron that referenced this issue Dec 16, 2021
You must either (1) have a case-insensitive file server (2) upload files in both casings. This improves the docs to clarify that.

[0]: electron#22482 (comment)
codebytere pushed a commit that referenced this issue Jan 10, 2022
You must either (1) have a case-insensitive file server (2) upload files in both casings. This improves the docs to clarify that.

[0]: #22482 (comment)
trop bot pushed a commit that referenced this issue Jan 10, 2022
You must either (1) have a case-insensitive file server (2) upload files in both casings. This improves the docs to clarify that.

[0]: #22482 (comment)
trop bot pushed a commit that referenced this issue Jan 10, 2022
You must either (1) have a case-insensitive file server (2) upload files in both casings. This improves the docs to clarify that.

[0]: #22482 (comment)
jkleinsc pushed a commit that referenced this issue Jan 10, 2022
You must either (1) have a case-insensitive file server (2) upload files in both casings. This improves the docs to clarify that.

[0]: #22482 (comment)

Co-authored-by: Evan Hahn <69474926+EvanHahn-Signal@users.noreply.github.com>
jkleinsc pushed a commit that referenced this issue Jan 10, 2022
You must either (1) have a case-insensitive file server (2) upload files in both casings. This improves the docs to clarify that.

[0]: #22482 (comment)

Co-authored-by: Evan Hahn <69474926+EvanHahn-Signal@users.noreply.github.com>
t57ser pushed a commit to t57ser/electron that referenced this issue Jan 25, 2022
You must either (1) have a case-insensitive file server (2) upload files in both casings. This improves the docs to clarify that.

[0]: electron#22482 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants