Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: properly forward properties to webview #22510

Merged
merged 1 commit into from Mar 4, 2020
Merged

fix: properly forward properties to webview #22510

merged 1 commit into from Mar 4, 2020

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Mar 3, 2020

Backport of #22485

See that PR for details.

Notes: Fixes some properties not working in webview tags.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 3, 2020
@trop trop bot requested a review from codebytere March 3, 2020 22:25
@trop trop bot mentioned this pull request Mar 3, 2020
Merged
4 tasks
@trop trop bot added 8-x-y backport This is a backport PR labels Mar 3, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Mar 3, 2020
@zcbenz zcbenz merged commit eb63062 into 8-x-y Mar 4, 2020
@release-clerk
Copy link

release-clerk bot commented Mar 4, 2020

Release Notes Persisted

Fixes some properties not working in webview tags.

@zcbenz zcbenz deleted the trop/8-x-y-bp-fix-properly-forward-properties-to-webview-1583274332401 branch March 4, 2020 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
8-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zcbenz @codebytere