fix: properly forward properties to webview #22485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
force-pushed
the
fix-webview-properties
branch
3 times, most recently
from
e926ad2 to
54c43db
Compare
codebytere
force-pushed
the
fix-webview-properties
branch
from
54c43db to
0fed812
Compare
codebytere
force-pushed
the
fix-webview-properties
branch
from
0fed812 to
87b5245
Compare
MarshallOfSound
approved these changes
Mar 2, 2020
zcbenz
approved these changes
Mar 3, 2020
|
Release Notes Persisted
|
This was referenced Mar 3, 2020
|
I have automatically backported this PR to "8-x-y", please check out #22510 |
|
I have automatically backported this PR to "9-x-y", please check out #22511 |
|
I have automatically backported this PR to "7-1-x", please check out #22512 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #20679
Adds handling for properties so that they are properly forwarded to webviews. Tested with this gist.
cc @MarshallOfSound @zcbenz @nornagon
Checklist
npm testpassesRelease Notes
Notes: Fixes some properties not working in webview tags.