build: enable JS semicolons #22783
Merged
build: enable JS semicolons #22783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkleinsc
approved these changes
Mar 20, 2020
nornagon
approved these changes
Mar 20, 2020
|
No Release Notes |
|
I was unable to backport this PR to "9-x-y" cleanly; |
|
I was unable to backport this PR to "8-x-y" cleanly; |
|
I was unable to backport this PR to "7-1-x" cleanly; |
|
@MarshallOfSound has manually backported this PR to "9-x-y", please check out #22785 |
|
@MarshallOfSound has manually backported this PR to "8-x-y", please check out #22786 |
|
@MarshallOfSound has manually backported this PR to "7-1-x", please check out #22787 |
sentialx
pushed a commit
to sentialx/electron
that referenced
this pull request
Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ASI is an error correcting strategy, it has exceptions instead of being a steadfast rule and all our new projects in the
electronorg are standardizing onprettierwith semicolons enabled. This is a quick--fixrun to put semicolons everywhere, making code more legible, easier to parse and standard across the electron orgNotes: no-notes