Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase max crash key value length #24782

Merged
merged 4 commits into from
Jul 30, 2020
Merged

Conversation

nornagon
Copy link
Member

Description of Change

This allows storing more complex data in the crash values, and will enable Sentry's reporter to switch away from their custom uploader.

This will waste memory for smaller crash keys, but most apps use only a small number of crash keys, so the excess won't be significant. In future, we can optimize this further by either separating crash keys into various classes by length, or expanding the API to allow the user to specify the maximum length of the key, or some other system.

Checklist

Release Notes

Notes: Increased maximum length for crash keys from 127B to 20KB.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 29, 2020
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
@MarshallOfSound MarshallOfSound merged commit d93bb34 into master Jul 30, 2020
@release-clerk
Copy link

release-clerk bot commented Jul 30, 2020

Release Notes Persisted

Increased maximum length for crash keys from 127B to 20KB.

@trop
Copy link
Contributor

trop bot commented Jul 30, 2020

I was unable to backport this PR to "10-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/10-x-y label Jul 30, 2020
@trop
Copy link
Contributor

trop bot commented Jul 30, 2020

I was unable to backport this PR to "9-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Aug 5, 2020

@nornagon has manually backported this PR to "10-x-y", please check out #24853

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 5, 2020
@trop trop bot added the in-flight/10-x-y label Aug 5, 2020
@trop
Copy link
Contributor

trop bot commented Aug 5, 2020

@nornagon has manually backported this PR to "9-x-y", please check out #24854

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants