-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: increase max crash key value length #24782
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarshallOfSound
approved these changes
Jul 29, 2020
MarshallOfSound
force-pushed
the
crashpad-value-length
branch
from
July 29, 2020 20:49
7b73073
to
445fdc1
Compare
MarshallOfSound
force-pushed
the
crashpad-value-length
branch
from
July 30, 2020 00:24
df9ca05
to
81186a3
Compare
nornagon
commented
Jul 30, 2020
Co-authored-by: Jeremy Rose <jeremya@chromium.org>
Release Notes Persisted
|
I was unable to backport this PR to "10-x-y" cleanly; |
I was unable to backport this PR to "9-x-y" cleanly; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This allows storing more complex data in the crash values, and will enable Sentry's reporter to switch away from their custom uploader.
This will waste memory for smaller crash keys, but most apps use only a small number of crash keys, so the excess won't be significant. In future, we can optimize this further by either separating crash keys into various classes by length, or expanding the API to allow the user to specify the maximum length of the key, or some other system.
Checklist
npm test
passesRelease Notes
Notes: Increased maximum length for crash keys from 127B to 20KB.