Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: increase max crash key value length #24853

Merged
merged 1 commit into from Aug 6, 2020
Merged

fix: increase max crash key value length #24853

merged 1 commit into from Aug 6, 2020

Conversation

nornagon
Copy link
Member

@nornagon nornagon commented Aug 5, 2020

Backport of #24782.

Notes: Increased maximum length for crash keys from 127B to 20KB.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 5, 2020
@trop trop bot mentioned this pull request Aug 5, 2020
Merged
7 tasks
@trop trop bot added 10-x-y backport This is a backport PR labels Aug 5, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 5, 2020
@codebytere codebytere changed the title fix: increase max crash key value length (#24782) fix: increase max crash key value length Aug 6, 2020
@codebytere codebytere merged commit 08fc9df into 10-x-y Aug 6, 2020
@release-clerk
Copy link

release-clerk bot commented Aug 6, 2020

Release Notes Persisted

Increased maximum length for crash keys from 127B to 20KB.

@codebytere codebytere deleted the backport/10-x-y/crashpad-value-length branch August 6, 2020 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
10-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nornagon @codebytere