Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: handle unhandled promise rejection in notes #24923

Merged
merged 6 commits into from Aug 10, 2020
Merged

build: handle unhandled promise rejection in notes #24923

merged 6 commits into from Aug 10, 2020

Conversation

codebytere
Copy link
Member

Description of Change

Handle any potential Git processes without throwing unhandled rejection errors.

cc @ckerr @MarshallOfSound

Checklist

Release Notes

Notes: none

@codebytere codebytere requested a review from a team as a code owner August 10, 2020 16:02
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 10, 2020
ckerr
ckerr approved these changes Aug 10, 2020
View reviewed changes
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still have questions about the root cause of this, but first things first let's get the release unblocked

codebytere and others added 2 commits August 10, 2020 09:35
@codebytere @MarshallOfSound
Update script/release/prepare-release.js
29b7869 
Co-authored-by: Samuel Attard <sattard@slack-corp.com>
@codebytere
Log out git command before running
12ed0f8
@codebytere codebytere changed the title chore: handle unhandled promise rejection in notes build: handle unhandled promise rejection in notes Aug 10, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 10, 2020
@codebytere codebytere merged commit 16c32d2 into master Aug 10, 2020
@release-clerk
Copy link

release-clerk bot commented Aug 10, 2020

No Release Notes

@codebytere codebytere deleted the no-unhandled-rejections branch August 10, 2020 17:18
ckerr added a commit that referenced this pull request Sep 3, 2020
@ckerr
chore: sync 10-x-y release notes script to master
87e3181 
* adds the '(Also in N-x-y)' annotations
* handle sublists in release notes (#25279)
* has prepare-release.js catch thrown exceptions (#24923)
* syncs related tests
@ckerr ckerr mentioned this pull request Sep 3, 2020
Merged
5 tasks
@trop
Copy link
Contributor

trop bot commented Sep 3, 2020

@ckerr has manually backported this PR to "10-x-y", please check out #25304

@trop trop bot added the in-flight/10-x-y label Sep 3, 2020
ckerr added a commit that referenced this pull request Sep 3, 2020
@ckerr
chore: sync 9-x-y release notes script to master
7e72da5 
* adds the '(Also in N-x-y)' annotations
* handle sublists in release notes (#25279)
* has prepare-release.js catch thrown exceptions (#24923)
* syncs related tests
@ckerr ckerr mentioned this pull request Sep 3, 2020
Merged
5 tasks
@trop
Copy link
Contributor

trop bot commented Sep 3, 2020

@ckerr has manually backported this PR to "9-x-y", please check out #25305

@trop trop bot added the in-flight/9-x-y label Sep 3, 2020
ckerr added a commit that referenced this pull request Sep 3, 2020
@ckerr
chore: sync 8-x-y release notes script to master
2db1f2f 
* adds the '(Also in N-x-y)' annotations
* handle sublists in release notes (#25279)
* has prepare-release.js catch thrown exceptions (#24923)
* syncs related tests
@ckerr ckerr mentioned this pull request Sep 3, 2020
Merged
5 tasks
@trop
Copy link
Contributor

trop bot commented Sep 3, 2020

@ckerr has manually backported this PR to "8-x-y", please check out #25306

@trop trop bot added the in-flight/8-x-y label Sep 3, 2020
zcbenz pushed a commit that referenced this pull request Sep 8, 2020
@ckerr
chore: sync 8-x-y release notes script to master (#25306)
32c7b35 
* adds the '(Also in N-x-y)' annotations
* handle sublists in release notes (#25279)
* has prepare-release.js catch thrown exceptions (#24923)
* syncs related tests
zcbenz pushed a commit that referenced this pull request Sep 8, 2020
@ckerr
chore: sync 9-x-y release notes script to master (#25305)
a90397f 
* adds the '(Also in N-x-y)' annotations
* handle sublists in release notes (#25279)
* has prepare-release.js catch thrown exceptions (#24923)
* syncs related tests
zcbenz pushed a commit that referenced this pull request Sep 8, 2020
@ckerr
chore: sync 10-x-y release notes script to master (#25304)
c6eeff8 
* chore: sync 10-x-y release notes script to master

* adds the '(Also in N-x-y)' annotations
* handle sublists in release notes (#25279)
* has prepare-release.js catch thrown exceptions (#24923)
* syncs related tests

* chore: update cache entries in release notes tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codebytere @ckerr @MarshallOfSound