-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: graceful handling of notes with sub-lists #25279
Conversation
Handle multine release notes that contain their own bullet points. Also, if a release note begins with a bullet point, remove it because it will confuse the markdown parser to have two bullet points.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ckerr do you have a before and after example of formatting with bullet points?
I'd also prefer we add some tests if possible! (lint is dying too)
@codebytere added in description
Added 3badf00
Fixed bd296fe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
No behavior change; just includes files that ought to be cached to prevent hitting octokit for them.
No Release Notes |
I have automatically backported this PR to "11-x-y", please check out #25312 |
Description of Change
Handle multine release notes that contain their own bullet points.
Also, if a release note begins with a bullet point, remove it because it will confuse the markdown parser to have two bullet points.
Before and After:
CC @codebytere @MarshallOfSound
Checklist
npm test
passesRelease Notes
Notes: none