Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

window.open doesn't work correctly in child window #25079

Closed
3 tasks done
CezaryKulakowski opened this issue Aug 21, 2020 · 2 comments
Closed
3 tasks done

window.open doesn't work correctly in child window #25079

CezaryKulakowski opened this issue Aug 21, 2020 · 2 comments

Comments

@CezaryKulakowski
Copy link
Contributor

CezaryKulakowski commented Aug 21, 2020

Preflight Checklist

  • I have read the Contributing Guidelines for this project.
  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for an issue that matches the one I want to file, without success.

Issue Details

  • Electron Version:
    • 11.0.0-nightly.20200814
  • Operating System:
    • Windows 10
  • Last Known Working Electron version:
    • unknown

Expected Behavior

window.open called in child window opens new window with requested url

Actual Behavior

If speculative render view host is deleted during naviagation to page we try to open with call to window.open window is destroyed right after it is created.

To Reproduce

  1. Create main window with web preference nativeWindowOpen set to true
  2. Create child window with call to window.open('about:blank') in the main window's dev tools console
  3. Create second child window with call to window.open('http://www.google.com') in the child's window dev tools console

Third window will be destroyed right after it is created.

Additional Information

I attached an example application which reproduces the problem.
window-open-app.zip

@CezaryKulakowski
Copy link
Contributor Author

I've created pr with fix for this issue: #25080

@sofianguy sofianguy added this to Unsorted Issues in 11-x-y Sep 1, 2020
@sofianguy sofianguy moved this from Unsorted Issues to Blocks Stable in 11-x-y Sep 2, 2020
@codebytere
Copy link
Member

Closed by #25080

@codebytere codebytere moved this from Blocks Stable to Fixed for Next Release in 11-x-y Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
11-x-y
Fixed for Next Release
Development

No branches or pull requests

3 participants