electron crashes when calling importCertificate

[notNotDaniel]

Preflight Checklist

• I have read the Contributing Guidelines for this project.
• I agree to follow the Code of Conduct that this project adheres to.
• I have searched the issue tracker for an issue that matches the one I want to file, without success.

Issue Details

• Electron Version:
  10.1.2
  9.3.1
  8.5.1

• Operating System:
  Ubuntu 18.04.05 x64
  Also under Ubuntu 16, 14, 12, and Fedora

• Last Known Working Electron version:
  7.3.3

Expected Behavior

Calling importCertificate should call the provided function with an error code indicating whether the certificate was successfully imported.

Actual Behavior

Calling importCertificate results in a crash (segmentation fault usually) under linux. This appears to happen across all versions of electron back to 7.x, on Ubuntu 12-18 and Fedora (tested in VirtualBox, and 18 on a bare-metal server). This appears to happen regardless of whether the cert and password are valid (or even specified).

To Reproduce

./node_modules/.bin/electron -i <<< "const {app} = require('electron'); app.importCertificate({},console.log);"
# Segfault

Screenshots

Additional Information

[concreted]

The fix for this issue appears to be in 10.1.5, but I am still seeing segfaults with Electron 10.1.5 on Ubuntu 20.04 LTS:

aric@aric-Surface-Go-2:~/src/photon$ electron -i <<< "const {app} = require('electron'); app.importCertificate({},console.log);"
> const {app} = require('electron'); app.importCertificate({},console.log);
/usr/local/share/.config/yarn/global/node_modules/electron/dist/electron exited with signal SIGSEGV
aric@aric-Surface-Go-2:~/src/photon$ electron --version
v10.1.5

Same results on:

• v12.0.0-nightly.20201026
• 11.0.0-beta.17

[concreted]

v9.3.3 works correctly for me.

[notNotDaniel]

After the fix I was still seeing segfaults under some versions if you call importCertificate immediately, however it does work now if you wait until the app is ready.

[codebytere]

if y'all are still seeing segfaults and can reproduce them at least somewhat reliably, feel free to open a new issue and ping me with a repro :) It's reasonable to wait until the app is ready, but we shouldn't be segfaulting even if you don't!

[concreted]

Ah, tried doing it after app ready and it doesn't segfault for me in 10.1.5. Can repro the segfault in 10.1.5 with @notNotDaniel's original repro steps (which do the import immediately) reliably though, will open a new issue. Thanks!