Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot click a button in a BrowserView -- MouseEvents are captured by drag? #26355

Closed
3 tasks done
ccorcos opened this issue Nov 5, 2020 · 3 comments · Fixed by #26496
Closed
3 tasks done

Cannot click a button in a BrowserView -- MouseEvents are captured by drag? #26355

ccorcos opened this issue Nov 5, 2020 · 3 comments · Fixed by #26496

Comments

@ccorcos
Copy link

ccorcos commented Nov 5, 2020

Preflight Checklist

  • I have read the Contributing Guidelines for this project.
  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for an issue that matches the one I want to file, without success.

Issue Details

  • Electron Version: v11.0.0-beta.19
  • Operating System: macOS 11.0.1
  • Last Known Working Electron version:

I've created a minimal repro for you. Download the repo:

git clone git@github.com:ccorcos/electron-browser-view-drag.git
cd electron-browser-view-drag
git checkout side-browser-view
npm install
npm start

There's a the default index.html inside the window's webview, and what I did is add a BrowserView to render search.html and you'll notice that button is not clickable. However, you can drag the whole window when you click in there...

Expected Behavior

Should be able to click the button inside a BrowserView.

@poiru
Copy link
Contributor

poiru commented Nov 6, 2020

It seems like there has been a regression in Electron 11. The BrowserView seems to always be a draggable region regardless of -webkit-app-region. Electron 10 works fine. cc @codebytere

@codebytere
Copy link
Member

@codebytere
Copy link
Member

@poiru i'm not sure what you mean and did not see drag behavior in frameless windows where none was enabled 🤔 Do you have a specific repro in mind?

@ccorcos PR is up to address this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants