Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: segfault on webContents.fromId(xxx) #26609

Merged
merged 1 commit into from
Nov 23, 2020
Merged

fix: segfault on webContents.fromId(xxx) #26609

merged 1 commit into from
Nov 23, 2020

Conversation

nornagon
Copy link
Member

Description of Change

Fixes #26599.

Checklist

Release Notes

Notes: Fixed a crash when calling webContents.fromId with an unknown ID.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Nov 19, 2020
@nornagon
Copy link
Member Author

also sent a fix upstream to gin: https://chromium-review.googlesource.com/c/chromium/src/+/2551303

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Nov 20, 2020
@nornagon nornagon merged commit 329494c into master Nov 23, 2020
@release-clerk
Copy link

release-clerk bot commented Nov 23, 2020

Release Notes Persisted

Fixed a crash when calling webContents.fromId with an unknown ID.

@nornagon nornagon deleted the web-contents-fromid branch November 23, 2020 17:21
@trop
Copy link
Contributor

trop bot commented Nov 23, 2020

I was unable to backport this PR to "11-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot mentioned this pull request Nov 23, 2020
Merged
@trop
Copy link
Contributor

trop bot commented Nov 23, 2020

I have automatically backported this PR to "12-x-y", please check out #26651

@nornagon nornagon mentioned this pull request Nov 23, 2020
Merged
@trop
Copy link
Contributor

trop bot commented Nov 23, 2020

@nornagon has manually backported this PR to "11-x-y", please check out #26652

nornagon added a commit that referenced this pull request Nov 23, 2020
@nornagon
fix: segfault on webContents.fromId(xxx) (#26609)
324021a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Segmentation fault when webContents.fromId() for non existing id
2 participants
@nornagon @jkleinsc