build: remove no longer needed arm64 macos patches #26650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkleinsc
added
backport-check-skip
4 tasks
deepak1556
approved these changes
Nov 23, 2020
There was a problem hiding this comment.
Also confirmed with upstream that the wasm patches are not correct https://bugs.chromium.org/p/chromium/issues/detail?id=1150060#c8
codebytere
approved these changes
Nov 23, 2020
|
No Release Notes |
10 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
As mentioned here #26313 (comment), these patches are no longer needed. This patch is just targeting 11-x-y because chore_add_v8_apple_silicon_patches.patch doesn't exist on master and
fix_use_proper_page_size_for_mac_arm64.patch gets removed in #24832
Checklist
npm testpassesRelease Notes
Notes: none