Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: enable arm64 macOS tests #24832

Merged
merged 2 commits into from
Jan 21, 2021
Merged

ci: enable arm64 macOS tests #24832

merged 2 commits into from
Jan 21, 2021

Conversation

jkleinsc
Copy link
Contributor

@jkleinsc jkleinsc commented Aug 4, 2020 •
edited
Loading

Description of Change

This PR enables testing of arm64 macOS builds.

Checklist

Release Notes

Notes: none

@jkleinsc jkleinsc requested a review from a team as a code owner August 4, 2020 17:51
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 4, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 5, 2020
@jkleinsc jkleinsc requested a review from a team as a code owner September 28, 2020 14:22
@jkleinsc jkleinsc removed the wip ⚒ label Sep 29, 2020
@jkleinsc jkleinsc changed the title [WIP] ci: enable arm2 tests ci: enable arm64 macOS tests Sep 29, 2020
@jkleinsc jkleinsc force-pushed the enable-arm2-tests branch 2 times, most recently from 77a5c96 to f224cc1 Compare October 19, 2020 21:02
@jkleinsc jkleinsc force-pushed the enable-arm2-tests branch 3 times, most recently from 02ff21f to 00f2f92 Compare November 4, 2020 16:37
@jkleinsc jkleinsc mentioned this pull request Nov 23, 2020
Closed
4 tasks
@jkleinsc jkleinsc mentioned this pull request Nov 23, 2020
Merged
3 tasks
@jkleinsc jkleinsc mentioned this pull request Jan 13, 2021
Closed
3 tasks
This was referenced Jan 14, 2021
Closed
Closed
@jkleinsc
Copy link
Contributor Author

Merging as CI failure is unrelated to PR changes.

@jkleinsc jkleinsc merged commit 034a792 into master Jan 21, 2021
@release-clerk
Copy link

release-clerk bot commented Jan 21, 2021

No Release Notes

@jkleinsc jkleinsc deleted the enable-arm2-tests branch January 21, 2021 23:36
@jkleinsc jkleinsc mentioned this pull request Apr 15, 2021
Closed
jviotti
jviotti reviewed Jun 8, 2021
View reviewed changes
azure-pipelines-arm.yml
@@ -17,6 +17,7 @@ steps:
node script/download-circleci-artifacts.js --buildNum=$CIRCLE_BUILD_NUM --name=dist.zip --dest=$ZIP_DEST
cd $ZIP_DEST
unzip -o dist.zip
xattr -cr Electron.app
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jkleinsc What is the reasoning behind clearing the extended attributes here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jviotti just to make sure the quarantine attribute is removed from the downloaded file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jviotti jviotti jviotti left review comments

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
semver/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jkleinsc @codebytere @jviotti