Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make screen wrapper remote-friendly again #26660

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Nov 23, 2020

Backport of #26620

See that PR for details.

Notes: Fixed screen methods not being accessible via remote.screen.

This restores accessibility of screen methods via remote.screen.

Fixes #26610.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Nov 23, 2020
@trop trop bot added 11-x-y backport This is a backport PR labels Nov 23, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Nov 23, 2020
Copy link

@Dour420 Dour420 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CONTENT DELETED

@jkleinsc jkleinsc merged commit 18cde2e into 11-x-y Nov 23, 2020
@release-clerk
Copy link

release-clerk bot commented Nov 23, 2020

Release Notes Persisted

Fixed screen methods not being accessible via remote.screen.

@trop trop bot deleted the trop/11-x-y-bp-fix-make-screen-wrapper-remote-friendly-again-1606167915272 branch November 23, 2020 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11-x-y backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants