Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Methods on remote.screen are not defined #26610

Closed
3 tasks done
andersk opened this issue Nov 20, 2020 · 2 comments · Fixed by #26620
Closed
3 tasks done

Methods on remote.screen are not defined #26610

andersk opened this issue Nov 20, 2020 · 2 comments · Fixed by #26620
Labels
11-x-y bug/regression ↩️ A new version of Electron broke something has-repro-gist Issue can be reproduced with code at https://gist.github.com/ platform/all status/confirmed A maintainer reproduced the bug or agreed with the feature

Comments

@andersk
Copy link
Contributor

andersk commented Nov 20, 2020 •
edited
Loading

Preflight Checklist

  • I have read the Contributing Guidelines for this project.
  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for an issue that matches the one I want to file, without success.

Issue Details

  • Electron Version:
    • 11.0.2
  • Operating System:
    • NixOS 21.03 x86_64
  • Last Known Working Electron version:
    • 10.1.6

Expected Behavior

remote.screen.getPrimaryDisplay() works.

Actual Behavior

Uncaught TypeError: remote.screen.getPrimaryDisplay is not a function

To Reproduce

Electron Fiddle: https://gist.github.com/andersk/6158c0016c56e52c58cec4aa4cd8317e

Additional Information

This broke between 11.0.0-nightly.20200724 and 11.0.0-nightly.20200729, probably in #24677. Cc @nornagon.

See also electron-userland/spectron#771, webtorrent/webtorrent-desktop#1896.
This was referenced Nov 20, 2020
Closed
Closed
@Augus
Copy link

Augus commented Nov 20, 2020

Both macOS11 and Windows 10 will have this problem.

@ckerr ckerr added 11-x-y has-repro-gist Issue can be reproduced with code at https://gist.github.com/ platform/macOS platform/windows status/confirmed A maintainer reproduced the bug or agreed with the feature platform/all bug 🪲 bug/regression ↩️ A new version of Electron broke something and removed platform/macOS platform/windows bug 🪲 labels Nov 20, 2020
@ckerr
Copy link
Member

ckerr commented Nov 20, 2020

Also confirmed on Linux as having broken between v10.1.6 and v11.0.2.

This is an Electron regression and should get fixed, but just a heads-up that remote is deprecated and in the long term you'll want to migrate away from this API.

andersk added a commit to andersk/electron that referenced this issue Nov 21, 2020
@andersk
screen: Fix lazy wrapper to be remote-friendly
e983547 
This restores accessibility of screen methods via remote.screen.

Fixes electron#26610.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
andersk added a commit to andersk/electron that referenced this issue Nov 21, 2020
@andersk
fix: make screen wrapper remote-friendly again
3fbdbd5 
This restores accessibility of screen methods via remote.screen.

Fixes electron#26610.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@andersk andersk mentioned this issue Nov 21, 2020
Merged
5 tasks
andersk added a commit to andersk/electron that referenced this issue Nov 21, 2020
@andersk
fix: make screen wrapper remote-friendly again
8feaf0c 
This restores accessibility of screen methods via remote.screen.

Fixes electron#26610.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
jkleinsc pushed a commit that referenced this issue Nov 23, 2020
@andersk
fix: make screen wrapper remote-friendly again (#26620)
b1b2560 
This restores accessibility of screen methods via remote.screen.

Fixes #26610.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
trop bot pushed a commit that referenced this issue Nov 23, 2020
@andersk @electron-bot
fix: make screen wrapper remote-friendly again
1340784 
This restores accessibility of screen methods via remote.screen.

Fixes #26610.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
trop bot pushed a commit that referenced this issue Nov 23, 2020
@andersk @electron-bot
fix: make screen wrapper remote-friendly again
04cd38b 
This restores accessibility of screen methods via remote.screen.

Fixes #26610.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
jkleinsc pushed a commit that referenced this issue Nov 23, 2020
@trop @andersk
fix: make screen wrapper remote-friendly again (#26660)
18cde2e 
This restores accessibility of screen methods via remote.screen.

Fixes #26610.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>

Co-authored-by: Anders Kaseorg <andersk@mit.edu>
jkleinsc pushed a commit that referenced this issue Nov 24, 2020
@trop @andersk
fix: make screen wrapper remote-friendly again (#26661)
4fbb580 
This restores accessibility of screen methods via remote.screen.

Fixes #26610.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>

Co-authored-by: Anders Kaseorg <andersk@mit.edu>
@nornagon nornagon mentioned this issue Dec 1, 2020
Closed
3 tasks
@AllanChain AllanChain mentioned this issue Dec 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
11-x-y bug/regression ↩️ A new version of Electron broke something has-repro-gist Issue can be reproduced with code at https://gist.github.com/ platform/all status/confirmed A maintainer reproduced the bug or agreed with the feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: make screen wrapper remote-friendly again andersk/electron
3 participants
@andersk @ckerr @Augus