-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Methods on remote.screen are not defined #26610
Labels
11-x-y
bug/regression ↩️
A new version of Electron broke something
has-repro-gist
Issue can be reproduced with code at https://gist.github.com/
platform/all
status/confirmed
A maintainer reproduced the bug or agreed with the feature
Comments
This was referenced Nov 20, 2020
Both macOS11 and Windows 10 will have this problem. |
Also confirmed on Linux as having broken between v10.1.6 and v11.0.2. This is an Electron regression and should get fixed, but just a heads-up that remote is deprecated and in the long term you'll want to migrate away from this API. |
andersk
added a commit
to andersk/electron
that referenced
this issue
Nov 21, 2020
This restores accessibility of screen methods via remote.screen. Fixes electron#26610. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
andersk
added a commit
to andersk/electron
that referenced
this issue
Nov 21, 2020
This restores accessibility of screen methods via remote.screen. Fixes electron#26610. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
5 tasks
andersk
added a commit
to andersk/electron
that referenced
this issue
Nov 21, 2020
This restores accessibility of screen methods via remote.screen. Fixes electron#26610. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
jkleinsc
pushed a commit
that referenced
this issue
Nov 23, 2020
This restores accessibility of screen methods via remote.screen. Fixes #26610. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
trop bot
pushed a commit
that referenced
this issue
Nov 23, 2020
This restores accessibility of screen methods via remote.screen. Fixes #26610. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
trop bot
pushed a commit
that referenced
this issue
Nov 23, 2020
This restores accessibility of screen methods via remote.screen. Fixes #26610. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
jkleinsc
pushed a commit
that referenced
this issue
Nov 23, 2020
This restores accessibility of screen methods via remote.screen. Fixes #26610. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Co-authored-by: Anders Kaseorg <andersk@mit.edu>
jkleinsc
pushed a commit
that referenced
this issue
Nov 24, 2020
This restores accessibility of screen methods via remote.screen. Fixes #26610. Signed-off-by: Anders Kaseorg <andersk@mit.edu> Co-authored-by: Anders Kaseorg <andersk@mit.edu>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
11-x-y
bug/regression ↩️
A new version of Electron broke something
has-repro-gist
Issue can be reproduced with code at https://gist.github.com/
platform/all
status/confirmed
A maintainer reproduced the bug or agreed with the feature
Preflight Checklist
Issue Details
Expected Behavior
remote.screen.getPrimaryDisplay()
works.Actual Behavior
Uncaught TypeError: remote.screen.getPrimaryDisplay is not a function
To Reproduce
Electron Fiddle: https://gist.github.com/andersk/6158c0016c56e52c58cec4aa4cd8317e
Additional Information
This broke between 11.0.0-nightly.20200724 and 11.0.0-nightly.20200729, probably in #24677. Cc @nornagon.
See also electron-userland/spectron#771, webtorrent/webtorrent-desktop#1896.
The text was updated successfully, but these errors were encountered: