Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron 11 breaks Error stack in a loaded iframe #26677

Closed
3 tasks done
sergeyd63 opened this issue Nov 24, 2020 · 7 comments · Fixed by #26820
Closed
3 tasks done

Electron 11 breaks Error stack in a loaded iframe #26677

sergeyd63 opened this issue Nov 24, 2020 · 7 comments · Fixed by #26820
Assignees
Labels
11-x-y 12-x-y bug/regression ↩️ A new version of Electron broke something has-repro-repo Issue can be reproduced by cloning a git repo platform/all
Projects

Comments

@sergeyd63
Copy link

Preflight Checklist

  • I have read the Contributing Guidelines for this project.
  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for an issue that matches the one I want to file, without success.

Issue Details

  • Electron Version:
    • 11.0.3
  • Operating System:
    • All
  • Last Known Working Electron version:
    • 10.1.6

Expected Behavior

Should send a full Error stack

Actual Behavior

In an iframe the error stack = "Error"

To Reproduce

Website has an iframe. On load the stack is not loaded

Screenshots

In a Browser (Chrome)
image

In Electron 11
image

Additional Information

@jnises
Copy link

jnises commented Dec 2, 2020

I'm getting the same issue. No iframes involved though.
In electron 10.1.6 i get this in the devconsole:
image
In electron 11.0.3 I get this:
image

This breaks my Sentry integration for example.

@VerteDinde VerteDinde added this to Unsorted Issues in 12-x-y Dec 2, 2020
@ckerr ckerr added the bug/regression ↩️ A new version of Electron broke something label Dec 3, 2020
@sofianguy sofianguy moved this from Unsorted Issues to Blocks Stable in 12-x-y Dec 3, 2020
@codebytere
Copy link
Member

codebytere commented Dec 3, 2020

It would be helpful if either of you could please provide a reproducible sample. I can reproduce this with contextIsolation enabled, and it's important for better triage that I know the exact conditions under which you see this so I'm not forced to make guesses.

@jnises
Copy link

jnises commented Dec 3, 2020

Yes. Only with contextIsolation.
Here is a minimal example: https://github.com/jnises/electron_stack_test

@ckerr ckerr added the has-repro-repo Issue can be reproduced by cloning a git repo label Dec 3, 2020
@codebytere
Copy link
Member

thanks @jnises! I'll see what i can do.

@codebytere
Copy link
Member

@jnises @sergeyd63 I've located the error and a fix is up

@jnises
Copy link

jnises commented Dec 3, 2020

great :)
that was quick

@sofianguy sofianguy moved this from Blocks Stable to Fixed for Next Release in 12-x-y Dec 10, 2020
@Raynos
Copy link

Raynos commented Dec 11, 2020

When will we have a new version of electron 11 that we can use that fixes this bug ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11-x-y 12-x-y bug/regression ↩️ A new version of Electron broke something has-repro-repo Issue can be reproduced by cloning a git repo platform/all
Projects
No open projects
12-x-y
Fixed for Next Release
Development

Successfully merging a pull request may close this issue.

6 participants