Add "role" attribute for MenuItem #2682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcbenz
added a commit
that referenced
this pull request
Sep 2, 2015
Add "role" attribute for MenuItem
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
roleattribute defines the action of the menu item, by using it users no longer need to manually write the behavior of standard menu items, and also fixed some menu items not working exactly the same with native ones (closes #2331).Also specifying special menus doesn't require hard-coding menu's name any more (closes #2348).
Also document the behavior that current menu item and window are passed when calling the
clickfunction (closes #935).