You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Update this event to emit an instance of WebFrameMain
Alternatives Considered
Should we instead be consistent with the API and provide isMainFrame, frameProcessId, and frameRoutingId? I think it'd eventually be nice if all navigation events could simply provide a reference to WebFrameMain.
Create a new event for sub frames called frame-dom-ready
Additional Information
I'll probably submit a PR for this myself soon enough. Any feedback before that would be appreciated!
The text was updated successfully, but these errors were encountered:
Preflight Checklist
Problem Description
The webContents 'dom-ready' event isn't emitted for any iframe navigation.
electron/shell/browser/api/electron_api_web_contents.cc
Lines 1434 to 1438 in 2be3d03
Proposed Solution
Update this event to emit an instance of
WebFrameMain
Alternatives Considered
Should we instead be consistent with the API and provide
isMainFrame
,frameProcessId
, andframeRoutingId
? I think it'd eventually be nice if all navigation events could simply provide a reference toWebFrameMain
.Create a new event for sub frames called
frame-dom-ready
Additional Information
I'll probably submit a PR for this myself soon enough. Any feedback before that would be appreciated!
The text was updated successfully, but these errors were encountered: