Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu 'role' of 'window' does not work #27645

Closed
3 tasks done
nkavian opened this issue Feb 6, 2021 · 13 comments
Closed
3 tasks done

Menu 'role' of 'window' does not work #27645

nkavian opened this issue Feb 6, 2021 · 13 comments
Labels
11-x-y 16-x-y component/menu has-repro-gist Issue can be reproduced with code at https://gist.github.com/ platform/macOS stale

Comments

@nkavian
Copy link

nkavian commented Feb 6, 2021

Preflight Checklist

  • I have read the Contributing Guidelines for this project.
  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for an issue that matches the one I want to file, without success.

Issue Details

  • Electron Version:
    • 11.2.0
  • Operating System:
    • macOS10.14.6
  • Last Known Working Electron version:
    • N/A

Expected Behavior

When using a Menu role of window it should show a list of BrowserWindows exactly the same as when using a role of windowMenu. This screenshot shows it correctly working with windowMenu.

image

Actual Behavior

When using a role of window, it simple displays a single submenu item labeled Window as seen in the picture below. You should instead see "Hello World!" listed 3 times.

image

To Reproduce

A very simple commit provided on the electron-quick-start: nkavian/electron-quick-start@78a244b

The example creates 3 windows and the relevant menu entries to show it works in windowMenu ("Window Menu 1") but broken with window ("Window Menu 2").

$ git clone git@github.com:nkavian/electron-quick-start.git
$ cd electron-quick-start
$ git checkout window-menu-bug
$ npm install
$ npm start
@ckerr
Copy link
Member

ckerr commented Feb 8, 2021

gist copy of repro, for easier triage: https://gist.github.com/ckerr/5a614cd82d6236a7bae011d9035994f5

nb:role: 'window' is a mac-only feature so this test must be run on macOS

@ckerr ckerr added the has-repro-gist Issue can be reproduced with code at https://gist.github.com/ label Feb 8, 2021
@wolfoo2931
Copy link

I might have a related problem.

When I'm starting the app in development mode I can cycle through the open windows by pressing [cmd]+[<].
When I'm building the app for MacOS and start the build the [cmd]+[<] key combination does not work anymore.

This worked before and stopped working at some point. Also, I tried to modify the menu to add all kinds of roles to it. It did not solve the problem.

@ericestes
Copy link

This is still an issue, v16.0.7.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2022

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

@github-actions github-actions bot added the stale label Oct 6, 2022
@nkavian
Copy link
Author

nkavian commented Oct 6, 2022

"bump"

@github-actions github-actions bot removed the stale label Oct 7, 2022
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

@github-actions github-actions bot added the stale label Jan 10, 2023
@nkavian
Copy link
Author

nkavian commented Jan 10, 2023

"bump"

@github-actions github-actions bot removed the stale label Jan 11, 2023
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

@github-actions github-actions bot added the stale label Apr 12, 2023
@nkavian
Copy link
Author

nkavian commented Apr 12, 2023

"bump"

@github-actions github-actions bot removed the stale label Apr 13, 2023
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

@github-actions github-actions bot added the stale label Jul 12, 2023
@nkavian
Copy link
Author

nkavian commented Jul 12, 2023

"bump"

@github-actions github-actions bot removed the stale label Jul 13, 2023
@electron-issue-triage
Copy link

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

@electron-issue-triage
Copy link

This issue has been closed due to inactivity, and will not be monitored. If this is a bug and you can reproduce this issue on a supported version of Electron please open a new issue and include instructions for reproducing the issue.

@electron-issue-triage electron-issue-triage bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11-x-y 16-x-y component/menu has-repro-gist Issue can be reproduced with code at https://gist.github.com/ platform/macOS stale
Projects
None yet
Development

No branches or pull requests

5 participants