[Bug]: setBounds make BrowserWindows larger every time on Windows #27651

Fndroid · 2021-02-08T12:24:11Z

Preflight Checklist

I have read the Contributing Guidelines for this project.
I agree to follow the Code of Conduct that this project adheres to.
I have searched the issue tracker for an issue that matches the one I want to file, without success.

Issue Details

Electron Version:
- 11.2.3
Operating System:
- Windows 10 20H2
Last Known Working Electron version:
- unknow

Expected Behavior

setBounds to output of getBounds makes no effect to BrowserWindows size

Actual Behavior

setBounds to output of getBounds makes BrowserWindows size larger every time setBounds called

To Reproduce

main.js

const { app, BrowserWindow } = require('electron')

function createWindow () {
  const win = new BrowserWindow({
    width: 801,
    height: 601,
    webPreferences: {
      nodeIntegration: true
    }
  })

  win.loadFile('index.html')

  let bounds = null

  win.on('minimize', () => {
    bounds = win.getBounds()
  })

  win.on('restore', () => {
    win.setBounds(bounds)
    console.log(win.getBounds())
  })
}

app.whenReady().then(createWindow)

app.on('window-all-closed', () => {
  if (process.platform !== 'darwin') {
    app.quit()
  }
})

app.on('activate', () => {
  if (BrowserWindow.getAllWindows().length === 0) {
    createWindow()
  }
})

index.html

<!DOCTYPE html>
<html>
<head>
    <meta charset="UTF-8">
    <title>Hello World!</title>
    <meta http-equiv="Content-Security-Policy" content="script-src 'self' 'unsafe-inline';" />
</head>
<body style="background: white;">
    <h1>Hello World!</h1>
    <p>
        We are using node <script>document.write(process.versions.node)</script>,
        Chrome <script>document.write(process.versions.chrome)</script>,
        and Electron <script>document.write(process.versions.electron)</script>.
    </p>
</body>
</html>

Screenshots

Additional Information

The text was updated successfully, but these errors were encountered:

pushkin- · 2021-02-08T15:26:11Z

Do you have a multi-monitor setup with different DPI settings? Kind of a related issue here with non-resizable windows.

ckerr · 2021-02-08T15:36:01Z

gist copy of @Fndroid's testcase: https://gist.github.com/ckerr/36a1dd373498591b58b2a788b3ec87da

ckerr · 2021-02-08T15:38:43Z

Might be an issue requiring a specific setup, e.g. Windows-only.

I'm not able to reproduce this on Ubuntu 20.10 with reported version. Tested by running the gist in Fiddle with Electron v11.2.3 and repeatedly minimizing / restoring the application's window. As per @pushkin's suggestion about multimonitor being a factor, I tried minimizing / restoring from both monitors on a multimonitor setup.

Output looked like this:

$ electron .
(node:1496992) electron: The default of contextIsolation is deprecated and will be changing from false to true in a future release of Electron.  See https://github.com/electron/electron/issues/23506 for more information
{ x: 559, y: 576, width: 801, height: 601 }
{ x: 559, y: 576, width: 801, height: 601 }
{ x: 559, y: 576, width: 801, height: 601 }
{ x: 2248, y: 583, width: 801, height: 601 }
{ x: 2248, y: 583, width: 801, height: 601 }
{ x: 2248, y: 583, width: 801, height: 601 }
Done in 25.31s.

The change in x, y between lines 3 and 4 is from me dragging the window to the second monitor.

pushkin- · 2021-02-08T16:23:10Z

I can repro this exactly on Windows 10, 2 monitors, and different DPI settings (the latter bit was key). The primary monitor is set to 125% and the second to 100%. Seems very much related to the linked issue.

Fndroid · 2021-02-09T02:42:30Z

It seems that this issue is related to the zoom factor of the system.

I tried 125%, 150%, 175%, 200% and 225% on a 3840x2160 monitor and all even numbers are fine but odd numbers are not.

Besides, macOS do not have this issue whild testing.

I think it might be a lead to locate the glitch.

alectrocute · 2021-02-11T13:56:29Z

+1. Can confirm it’s related to mis-matched display zoom settings on >1 monitor setups with Windows 10.

@Fndroid’s explanation is the best I’ve seen so far! Does indeed look related to odd zoom numbers.

reznikartem · 2021-05-31T14:26:54Z

Having same issue on Windows 10, 11.2.2

Have 2 displays with 3840x2160 resolultion, both on 175% dpi.

github-actions · 2022-10-06T02:22:07Z

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

pushkin- · 2022-10-06T18:07:06Z

repros in Electron 21

liuyike98 · 2022-10-08T09:32:50Z

It seems that this issue is related to the zoom factor of the

same to you, any solution?

skandaswamygit · 2022-10-20T23:53:39Z

I have the same problem when scaling a window across all displays of varying scale factor. I am presently sticking to an implementation that works only on monitors with same scale factor. It's not ideal. A solution for this is greatly appreciated.

github-actions · 2023-01-19T02:04:30Z

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

mikekreeki · 2023-01-19T06:42:01Z

Still an issue.

eltonchan · 2023-02-24T06:51:50Z

repros in Electron 20

vavdav · 2023-03-24T08:16:38Z

I had the same issue, it made infinite loop and frozen the app

FE-Acmen · 2023-06-07T08:42:45Z

OK，I also had this problem

electron-issue-triage · 2023-09-06T01:48:37Z

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

pushkin- · 2023-09-06T14:29:51Z

bump

fanchenio · 2023-11-21T01:07:21Z

Bump.

davidtheweb-dev · 2023-12-20T08:37:39Z

bump

oalfroukh · 2024-01-25T10:49:25Z

Hi Electron Team,
Any update for this old issue?

Thanks in advance!

c-o-c-o · 2024-03-01T14:50:48Z

There is still an issue.

courtsimas · 2024-04-16T04:10:06Z

Yep still an issue in electron 30.

ckerr added 11-x-y bug 🪲 component/BrowserWindow platform/windows has-repro-gist Issue can be reproduced with code at https://gist.github.com/ labels Feb 8, 2021

ckerr added the status/reviewed A maintainer made an initial review but not reproduced the issue label Feb 8, 2021

deepak1556 added this to Unsorted Issues in 12-x-y Feb 10, 2021

sofianguy assigned deepak1556 Feb 11, 2021

sofianguy moved this from Unsorted Issues to Does Not Block Stable in 12-x-y Feb 11, 2021

zcbenz mentioned this issue Feb 17, 2021

window.setSize: height is incorrect at custom DPI settings #27742

Closed

3 tasks

bpasero mentioned this issue Jun 9, 2021

[Bug]: BrowserWindow.getBounds() cannot be restored as they were in this case with multiple monitors and differing scale levels #29605

Open

3 tasks

github-actions bot added the stale label Oct 6, 2022

github-actions bot removed the stale label Oct 7, 2022

deepak1556 removed their assignment Oct 10, 2022

deepak1556 added 21-x-y 22-x-y and removed 11-x-y labels Oct 10, 2022

bpasero mentioned this issue Dec 29, 2022

Window restores with different bounds each restart microsoft/vscode#170001

Open

github-actions bot added the stale label Jan 19, 2023

github-actions bot removed the stale label Jan 20, 2023

dsanders11 changed the title ~~setBounds make BrowserWindows larger every time on Windows~~ [Bug]: setBounds make BrowserWindows larger every time on Windows Feb 6, 2023

rak-phillip mentioned this issue Mar 31, 2023

Position and scale the extensions browserview based on renderer content rancher-sandbox/rancher-desktop#4330

Merged

electron-issue-triage bot added the stale label Sep 6, 2023

electron-issue-triage bot removed the stale label Sep 7, 2023

dsanders11 added status/confirmed A maintainer reproduced the bug or agreed with the feature and removed status/reviewed A maintainer made an initial review but not reproduced the issue labels Sep 11, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Bug]: setBounds make BrowserWindows larger every time on Windows #27651

[Bug]: setBounds make BrowserWindows larger every time on Windows #27651

Fndroid commented Feb 8, 2021

pushkin- commented Feb 8, 2021

ckerr commented Feb 8, 2021 •

edited

ckerr commented Feb 8, 2021 •

edited

pushkin- commented Feb 8, 2021

Fndroid commented Feb 9, 2021 •

edited

alectrocute commented Feb 11, 2021 •

edited

reznikartem commented May 31, 2021

github-actions bot commented Oct 6, 2022

pushkin- commented Oct 6, 2022

liuyike98 commented Oct 8, 2022

skandaswamygit commented Oct 20, 2022

github-actions bot commented Jan 19, 2023

mikekreeki commented Jan 19, 2023

eltonchan commented Feb 24, 2023

vavdav commented Mar 24, 2023

FE-Acmen commented Jun 7, 2023

electron-issue-triage bot commented Sep 6, 2023

pushkin- commented Sep 6, 2023

fanchenio commented Nov 21, 2023

davidtheweb-dev commented Dec 20, 2023

oalfroukh commented Jan 25, 2024

c-o-c-o commented Mar 1, 2024

courtsimas commented Apr 16, 2024

[Bug]: setBounds make BrowserWindows larger every time on Windows #27651

[Bug]: setBounds make BrowserWindows larger every time on Windows #27651

Comments

Fndroid commented Feb 8, 2021

Preflight Checklist

Issue Details

Expected Behavior

Actual Behavior

To Reproduce

Screenshots

Additional Information

pushkin- commented Feb 8, 2021

ckerr commented Feb 8, 2021 • edited

ckerr commented Feb 8, 2021 • edited

pushkin- commented Feb 8, 2021

Fndroid commented Feb 9, 2021 • edited

alectrocute commented Feb 11, 2021 • edited

reznikartem commented May 31, 2021

github-actions bot commented Oct 6, 2022

pushkin- commented Oct 6, 2022

liuyike98 commented Oct 8, 2022

skandaswamygit commented Oct 20, 2022

github-actions bot commented Jan 19, 2023

mikekreeki commented Jan 19, 2023

eltonchan commented Feb 24, 2023

vavdav commented Mar 24, 2023

FE-Acmen commented Jun 7, 2023

electron-issue-triage bot commented Sep 6, 2023

pushkin- commented Sep 6, 2023

fanchenio commented Nov 21, 2023

davidtheweb-dev commented Dec 20, 2023

oalfroukh commented Jan 25, 2024

c-o-c-o commented Mar 1, 2024

courtsimas commented Apr 16, 2024

ckerr commented Feb 8, 2021 •

edited

ckerr commented Feb 8, 2021 •

edited

Fndroid commented Feb 9, 2021 •

edited

alectrocute commented Feb 11, 2021 •

edited