Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ECDH.setPrivateKey correctly sets the key #27688

Merged
merged 4 commits into from Feb 11, 2021
Merged

fix: ECDH.setPrivateKey correctly sets the key #27688

merged 4 commits into from Feb 11, 2021

Conversation

nornagon
Copy link
Member

@nornagon nornagon commented Feb 9, 2021

Description of Change

Fixes #27687.

Checklist

Release Notes

Notes: Fixed ECDH.setPrivateKey() not updating the key.

@nornagon nornagon requested a review from a team as a code owner February 9, 2021 19:13
@nornagon nornagon added semver/patch backwards-compatible bug fixes target/12-x-y labels Feb 9, 2021
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 9, 2021
ckerr
ckerr reviewed Feb 9, 2021
View reviewed changes
Copy link
Member

@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to add a regression test for this?

@nornagon
Copy link
Member Author

@ckerr this undisables the node test which would have caught this.

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 10, 2021
@codebytere
Copy link
Member

@nornagon mind rebasing?

@nornagon nornagon merged commit 4ce9dd3 into master Feb 11, 2021
@release-clerk
Copy link

release-clerk bot commented Feb 11, 2021

Release Notes Persisted

Fixed ECDH.setPrivateKey() not updating the key.

@nornagon nornagon deleted the fix-ecdh-setprivatekey branch February 11, 2021 21:49
@trop
Copy link
Contributor

trop bot commented Feb 11, 2021

I was unable to backport this PR to "12-x-y" cleanly;
you will need to perform this backport manually.

shnybans
shnybans suggested changes Feb 20, 2021
View reviewed changes
Copy link

@shnybans shnybans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • _**````

@nornagon nornagon mentioned this pull request Feb 22, 2021
Merged
@trop
Copy link
Contributor

trop bot commented Feb 22, 2021

@nornagon has manually backported this PR to "12-x-y", please check out #27856

nornagon added a commit that referenced this pull request Feb 22, 2021
@nornagon
fix: ECDH.setPrivateKey correctly sets the key (#27688)
ef3955a
zcbenz pushed a commit that referenced this pull request Feb 24, 2021
@nornagon @codebytere
fix: ECDH.setPrivateKey correctly sets the key (#27688) (#27856)
f0c7789 
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
@codebytere codebytere mentioned this pull request Jun 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr left review comments

@shnybans shnybans shnybans requested changes

@jkleinsc jkleinsc jkleinsc approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ECDH.setPrivateKey() is a noop since v12.0.0-nightly.20201014
5 participants
@nornagon @codebytere @ckerr @jkleinsc @shnybans