Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ECDH.setPrivateKey correctly sets the key #27856

Merged
merged 2 commits into from
Feb 24, 2021

Conversation

nornagon
Copy link
Member

Backport of #27688.

Notes: Fixed ECDH.setPrivateKey() not updating the key.

@nornagon nornagon requested a review from a team as a code owner February 22, 2021 17:28
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Feb 22, 2021
@trop trop bot added 12-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Feb 22, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Feb 22, 2021
@nornagon nornagon changed the title fix: ECDH.setPrivateKey correctly sets the key (#27688) fix: ECDH.setPrivateKey correctly sets the key Feb 22, 2021
@zcbenz
Copy link
Contributor

zcbenz commented Feb 24, 2021

All the failing tests are not related to this PR.

@zcbenz zcbenz merged commit f0c7789 into 12-x-y Feb 24, 2021
@release-clerk
Copy link

release-clerk bot commented Feb 24, 2021

Release Notes Persisted

Fixed ECDH.setPrivateKey() not updating the key.

@zcbenz zcbenz deleted the backport/12-x-y/fix-ecdh-setprivatekey branch February 24, 2021 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
12-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants