[Bug]: 'close' event is not triggered for sandboxed windows

[ChALkeR]

Preflight Checklist

• I have read the Contributing Guidelines for this project.
• I agree to follow the Code of Conduct that this project adheres to.
• I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Electron Version

12.0.1, 11.3.0, 10.4.1

What operating system are you using?

Other Linux

Operating System Version

Linux workstation 5.11.6-arch1-1 #1 SMP PREEMPT Thu, 11 Mar 2021 13:48:23 +0000 x86_64 GNU/Linux

What arch are you using?

x64

Last Known Working Electron version

No response

Expected Behavior

close event should be triggered when the webpage closes itself with window.close(), as it is for non-sandboxed contexts.

Actual Behavior

close event is not triggered on window.close() from inside the webpage for sandboxed contexts.

Testcase Gist URL

https://gist.github.com/cecc82a9d8ee56d01aa97b4c716eea9e

Testcase:

const { app, BrowserWindow } = require('electron')
app.whenReady().then(() => {
  const win = new BrowserWindow({
    width: 800, height: 600,
    webPreferences: {
      // sandbox: false, // works
      sandbox: true, // broken
    }
  })
  win.loadFile('about:blank')
  win.on('close', () => { console.log('close') }) // not triggered if broken
  win.on('closed', () => { console.log('closed') })
  setTimeout(() => {
    win.webContents.executeJavaScript('window.close()') // broken
    // win.close() // works
  }, 0)
})

Here, executeJavaScript is not necessary -- the page can do the same itself, or that could be alternatively done from devtools.

• If the window is closed externally (via .close() method of BrowserWindow instance, or via Alt-F4 or other OS/DE method), close event is always triggered.

• If sandbox is not enabled, close event is always triggered.

• closed (as opposed to close) event is also triggered if the window was closed.

• If the window closes itself with window.close() and it's sandboxed -- close event doesn't get triggered.

[nornagon]

NB. I copied your repro to a Fiddle-compatible gist for easy Fiddling. I can indeed reproduce this.

[nornagon]

Interestingly, win.webContents.on("close") does get emitted.

[ChALkeR]

Is win.webContents.on("close") documented somewhere?
Also, seems to be no way to prevent the window close action from there.

[nornagon]

Is win.webContents.on("close") documented somewhere?

Huh, apparently not.

Also, seems to be no way to prevent the window close action from there.

gotcha, yeah it makes sense that it should be possible to prevent the window close.

[github-actions]

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

[schontz]

Bump

[github-actions]

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

[ChALkeR]

bump, this looks still valid

[github-actions]

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

[pushkin-]

repros in v24

[github-actions]

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

[pushkin-]

bump

[schontz]

Tested the original fiddle on v25.2.0 and verified that this is still broken.

[electron-issue-triage]

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

[pushkin-]

repros in v27

[electron-issue-triage]

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

[pushkin-]

repros in v29 alpha 8

[pushkin-]

Note that in my case, I have a window with multiple BrowserViews in it (like tabs). This case needs to be considered when fixing this since fixing this in the naive way would mean that when one webContents closes, the entire window closes, which isn't really appropriate. It seems like it only makes sense for the "close" event to fire when there are no other webContents in the BrowserWindow.

[rafaberaldo]

It's a weird little inconsistency, although pretty easily to workaround.