Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: libuv hang on Windows #28336

Merged

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Mar 22, 2021

Backport of #28175

See that PR for details.

Notes: Fixed an issue where some Node.js modules would hang on page reload on Windows.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 22, 2021
@trop trop bot requested a review from codebytere March 22, 2021 20:12
@trop trop bot mentioned this pull request Mar 22, 2021
3 tasks
@trop trop bot added 11-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Mar 22, 2021
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Mar 22, 2021
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codebytere looks like the newly added test is failing

@aabuhijleh
Copy link

@codebytere please merge this PR

@jkleinsc jkleinsc merged commit bb031bf into 11-x-y Apr 28, 2021
@release-clerk
Copy link

release-clerk bot commented Apr 28, 2021

Release Notes Persisted

Fixed an issue where some Node.js modules would hang on page reload on Windows.

@jkleinsc jkleinsc deleted the trop/11-x-y-bp-fix-libuv-hang-on-windows-1616443957059 branch April 28, 2021 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
11-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants